Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Closes #156 |
src/server.rs
Outdated
| debug!(message = "execution mode is disabled, skipping FCU call to builder", "head_block_hash" = %fork_choice_state.head_block_hash); | ||
| } else if should_send_to_builder { | ||
| let builder_client = self.builder_client.clone(); | ||
| println!("print payload attributes: {:?}", payload_attributes); |
|
Can we update the |
|
|
||
| let l2_req = HttpRequest::from_parts(parts, HttpBody::from(body_bytes)); | ||
| info!(target: "proxy::call", message = "proxying request to rollup-boost server", ?method); | ||
| info!(target: "proxy::call", message = "forward request to rollup-boost server", ?method); |
There was a problem hiding this comment.
I think it would make sense to prefix our targets with rollup_boost since our OTLP filter is on rollup_boost targets.
Line 112 in eca9266
Not really relevant to this PR, but I think it would make sense to set rollup_boost as the target on all traces
src/integration/service_reth.rs
Outdated
| .arg("never") | ||
| .arg("--ipcdisable"); | ||
| .arg("--ipcdisable") | ||
| .arg("-vvvvv"); |
There was a problem hiding this comment.
do we want to enable tracing here on reth? seems it would be too verbose
| mint: None, | ||
| value: U256::default(), | ||
| gas_limit: 210000, | ||
| is_system_transaction: true, |
There was a problem hiding this comment.
does this deposit tx work? had to set is_system_transaction: false for it to work in op-rbuilder
There was a problem hiding this comment.
Our integration tests are running in an old (two weeks) version of Reth
0xOsiris
left a comment
0xOsiris
left a comment
There was a problem hiding this comment.
LGTM, nice work on this!
4 participants
Main scaffolding is done, tests blocked by paradigmxyz/reth#15435
Builder-playground test
Build local docker image:
Clone builder-playground at run the op-stack with the new image:
Testing
We cannot do integration tests yet because there is not a nightly release available yet for
op-reth. But, in the Kurtosis setup I am enabling theIshtmusandPraguefork after 2 blocks.